Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to un-ignore bots #25

Closed
rpdelaney opened this issue Oct 26, 2022 · 6 comments
Closed

Add an option to un-ignore bots #25

rpdelaney opened this issue Oct 26, 2022 · 6 comments

Comments

@rpdelaney
Copy link

For instance, I'm interested in ancient dependabot PRs because that usually means CI is broken on main. We're also migrating from dependabot to renovatebot, so it would be useful if I could un-ignore specific bots (i.e. to find repos where dependabot isn't fully gone).

@rpdelaney
Copy link
Author

There are different ways of achieving this. Off the top, you might create a configuration keyword to un-ignore specific users. If used, it would over-ride the bot-ignoring behavior. For instance, something like ignore_users: NOT dependabot NOT renovatebot. That wouldn't break existing configurations, and it would satisfy my user story.

You could also create a configuration keyword that means "all bots" so that a user who wants every bot to show up could do ignore_users: NOT %bots%, or ignore_users: %bots% NOT renovatebot etc.

@nedbat
Copy link
Owner

nedbat commented Oct 27, 2022

I added an include_bots: true setting that I think does what you want:

pip install git+https://github.com/nedbat/dinghy.git@nedbat/include-bots

Let me know if it seems right to you. I wonder if the bot users should be indicated somehow in the output?

@rpdelaney
Copy link
Author

rpdelaney commented Nov 2, 2022

Yeah, that seems to do the thing.

I wonder if the bot users should be indicated somehow in the output?

It would be useful if I could group them separately. Maybe just bots: true means I get only bots? Then I could do this:

---
digests:
  - digest: humans.html
    since: forever
    title: Trussworks Humans
    items:
      - search: org:trussworks is:open archived:false no:assignee    type:pr
        title: Pull requests
  - digest: bots.html
    since: forever
    title: Trussworks Bots
    bots: true  # <-- 
    items:
      - search: org:trussworks is:open archived:false no:assignee    type:pr
        title: Pull requests

@nedbat
Copy link
Owner

nedbat commented Nov 10, 2022

I want to merge this as-is, and we can talk about bots: true (or whatever) in another place.

@nedbat
Copy link
Owner

nedbat commented Nov 10, 2022

This is finished in commit e732d95.

@nedbat nedbat closed this as completed Nov 10, 2022
@nedbat
Copy link
Owner

nedbat commented Nov 10, 2022

This is now released as part of dinghy 0.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants