Add support for cabal files #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no experience with cabal files, but this seems fine. I would like to have a test added for the new code, and perhaps even a mention in the docs? |
|
I don't know exactly how the tests work, but I replicated what was already there this time for a very minimal cabal literal file. Is this ok? |
|
Thanks! |
nedbat
pushed a commit
that referenced
this pull request
Apr 30, 2023
|
This is now released as part of scriv 1.4.0. |
github-merge-queue bot
pushed a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Jan 5, 2024
- Update flake inputs - Update HLS to 2.5 - Use upstream scriv as nedbat/scriv#91 was merged and released in 1.4.0 (latest is 1.5.1 already).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cabal uses its own syntax for the descriptions of the packages, which we can parse ad-hoc for the version number under normal circumstances just by grepping for the
versionstring and getting the value after the colon.This is a non-invasive change that we would be interested in upstreaming so that there is not a fork just for this purpose.