Backward compatibility with Laravel 5.2 and Laravel 5.3 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bogdanghervan
commented
May 17, 2020
•
bogdanghervan
commented
- Prefer make() to makeWith() for backward compatibility with Laravel 5.3 (makeWith() is an alias for make() anyway)
- Implement abstract register() method in base service provider
|
I didn't break the tests, they were broken before. |
bogdanghervan
commented
May 26, 2020
| */ | ||
| public function boot() | ||
| public function register() |
There was a problem hiding this comment.
I'm declaring register() which is an abstract method in the base service provider in Laravel 5.2. Also, I deemed it safe to move the methods that bind stuff to the service container here.
publishConfig and registerCommands are still better located inside the boot() method according to the Laravel docs on packages.
bogdanghervan
changed the title
adrian-tilita
approved these changes
May 27, 2020
adrian-tilita
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.