Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Shader Graph Shaders with Custom Function Node have Invalid Conditional Expression errors #16

Closed
ROBYER1 opened this issue Aug 26, 2022 · 3 comments

Comments

@ROBYER1
Copy link

ROBYER1 commented Aug 26, 2022

Using 2020.3.38f1 and Needle Engine Starter Project, I was trying to make a shadow catcher material using this https://brownbot.com/2021/03/09/realtime-ar-shadows-unity-shader-graph/

In the Shader, I get errors about 'Invalid Conditional Expression'

image

Pretty much the same as this project and the file in it: https://github.com/Unity-Technologies/arfoundation-demos/blob/master/Assets/Shaders/Shadows/ShaderGraphs/TransparentShadowReceiver.shadergraph

Not sure if this is an error with the URP version or Needle? Is there an alternative for transparent AR plane shadow catching?

@ROBYER1
Copy link
Author

ROBYER1 commented Aug 26, 2022

Also I tried this shader from here https://forum.unity.com/threads/water-shader-graph-transparency-and-shadows-universal-render-pipeline-order.748142/#post-5518747 and it doesn't export correctly either, it exports as a solid colour

@hybridherbst
Copy link
Contributor

@ROBYER1 the above screenshot looks like you're already getting errors in Unity. We're not influencing the workings of URP in any way (really only exporting the results), so you should first make sure that is working as intended.

Also a heads-up, as the docs mention custom shaders + lighting aren't supported right now – same goes for shadows. I believe you should be able to export a regular plane though and properly configure on three.js side to get the behaviour you want.

@ROBYER1
Copy link
Author

ROBYER1 commented Aug 26, 2022

I'll give that a shot thanks!

@ROBYER1 ROBYER1 closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants