Skip to content

Commit

Permalink
graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal
Browse files Browse the repository at this point in the history
Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
  • Loading branch information
neersighted committed Feb 3, 2023
1 parent 0de3269 commit 3bcb350
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions daemon/graphdriver/overlay2/check.go
Expand Up @@ -188,6 +188,11 @@ func usingMetacopy(d string) (bool, error) {
// ...and check if the pulled-up copy is marked as metadata-only
xattr, err := system.Lgetxattr(filepath.Join(l2, "f"), overlayutils.GetOverlayXattr("metacopy"))
if err != nil {
// ENOTSUP signifies the FS does not support either xattrs or metacopy. In either case,
// it is not a fatal error, and we should report metacopy as unused.
if errors.Is(err, unix.ENOTSUP) {
return false, nil
}
return false, errors.Wrap(err, "metacopy flag was not set on file in the upperdir")
}
usingMetacopy := xattr != nil
Expand Down

0 comments on commit 3bcb350

Please sign in to comment.