jQuery empty() #59
Closed
jQuery empty() #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wonder if this method for clearing could lead to memory leaks, for example, callback with Interval or Timeout attached in these destroyed elements. |
|
@kafeltz it may cause memory leaks, but the reason is up to the developer. Before destroying elements, one should clean all interval or event listeners bind to that elements manually. It's easy to extract a method to do this automatically for a project, but it's hard or impossible to make that method suitable for all projects. @annamalai-saro can you fix the conflicts? |
|
@camsong @annamalai-saro agreed, it's like to create a "destroy" function pattern in the class. But it's good to be aware of this problem. |
camsong
added a commit
that referenced
this pull request
Jan 4, 2016
arcthur
added a commit
that referenced
this pull request
Jan 4, 2016
* 'master' of https://github.com/oneuijs/You-Dont-Need-jQuery: (94 commits) format: code add promise section feat(utils): add other utils method clean: adjust format feat(DOM): add `unwrap()` and `replaceWith()` feat(DOM): add `.wrap()` method update ko-KR add jquery empty and close #59 Update README-ru.md Update README.md map tweat inArray Update README-ru.md Update README-ru.md update ko-KR Update README.zh-CN.md add more tests update README update readme ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.