-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Recent changes on default gnome-shell theme make password entry box to be hardly readable #176
Comments
Yeah, it's not really ideal. Ultimately the extension isn't actually running when the lock-screen is active (that is possible but requires more hoops to jump through to get approval). I'm thinking of a few ideas but haven't come close to prototyping it. One option would be to split the extension so that we do the blur (and whatever features we want), but keep the code clean and easier to audit which is important for a lock-screen. Then it might be possible to inject a blurred backdrop to the login dialogs. Just an idea atm though. |
Maybe blur could be kept for the prompt screen. It seems it is the way gnome-shell-extension-unlockDialogBackground is handling this problem 🤔 |
That is a good idea, yeah. In this case, it might be better for me to just advise people use the unlock dialog extension and remove this code from Bing Wallpaper. |
But that extension is different, is not as simple as https://github.com/PRATAP-KUMAR/control-blur-effect-on-lock-screen , it forces the user to set a "hard coded" image to be shown in the lock screen. Indeed, if I enable both, unlockdialogbackground extension will simply make lock screen to show a blue background is I don't manually set an image |
Ok I have a working implementation of this now, feel free to test #189 if you are adventurous. I'm comfortable with what we are doing, but two things of note. Secondly, we need to keep the Blur object active for this to work, which means we aren't disabling every part of the extension when the lockscreen is active. This isn't 100% compatible with EGO review guidelines seen here. We could explicitly ask for the whole extension to remain active during both session mode in metadata, but would be problematic. An alternative would be to have this part of the extension separate from Bing Wallpaper. (It's something I considered, and may be forced when it gets reviewed.) |
Sorry for the late reply, it works fine! Thanks a lot |
Describe the bug
With latest gnome-shell default theme updates (I think they were introduced in Gnome 41 cycle), the password entry box was made transparent, that makes the box hardly readable when the extension is configured to get a fully transparent lock screen and a brilliant wallpaper is used.
Maybe the entry box theme could be tweaked back to safer transparency/color options :/
Thanks a lot
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: