Add support for jpeg images and custom quality #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neg4n
added
enhancement
|
Hey @transitive-bullshit, thanks for implementing it 馃殌 |
neg4n
approved these changes
Apr 5, 2022
|
Thanks @neg4n 馃挭 This'll get merged in soon transitive-bullshit/nextjs-notion-starter-kit#256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢 this project is great.
The only change I needed to make was that the output
pngimages are really large, and for most social images,jpegwill be a better option.Here's an example:
(png; 217KB)
(jpeg with 75% quality; 44KB)
This is for my next.js starter kit: https://github.com/transitive-bullshit/nextjs-notion-starter-kit