disable DVB support to fix building against linux 5.14 headers #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes building MPV on Fedora 35+ (and will probably have to be backported to Fedora 34 as well, once the kernel is updated to 5.14 there too). The /usr/include/linux/dvb/video.h header file has been (re)moved, with the DVB drivers having been moved to the staging tree.
|
Oh, this is very unfortunate. There seem to be no upstream fix in mpv yet as far as I'm seeing it :( |
|
It seems the issue has also not yet been reported upstream, so I've done that now: |
|
There is now a PR (merged) that just removed the no longer available includes, seems like those weren’t needed anyway. Pulling that commit (mpv-player/mpv@5bf92b6 ) downstream here is a better alternative until a new mpv release arrives. |
|
I think cherry-picking the obvious patch from upstream is a better idea than to disable the functionality, so I'll close my PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes building MPV on Fedora 35+ (and will probably have to be backported to Fedora 34 as well, once the kernel is updated to 5.14 there too).
The /usr/include/linux/dvb/video.h header file has been (re)moved, with the DVB drivers having been moved to the staging tree. A similar change has already been pushed to RPMFusion:
https://pkgs.rpmfusion.org/cgit/free/mpv.git/commit/?id=3a4f1a953af326e25e733c0833e33fe226442945