Minor refactoring/cleanup

negomi · Apr 3, 2018 · 4a39155 · 4a39155
1 parent cfcd8db
commit 4a39155
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 16 deletions.
diff --git a/example/src/example.less b/example/src/example.less
@@ -32,7 +32,7 @@ main {
   padding: 3em 2em;
   text-align: center;
   background: #b4bad2;
-  overflow: scroll;
+  overflow: auto;
 }
 
 h1 {

diff --git a/lib/baseStyles.js b/lib/baseStyles.js
@@ -56,10 +56,6 @@ var styles = {
       display: 'block',
       outline: 'none'
     };
-  },
-
-  burgerIcon: function burgerIcon(isOpen, width, right) {
-    return {};
   }
 };
 

diff --git a/lib/menuFactory.js b/lib/menuFactory.js
@@ -162,9 +162,9 @@ exports['default'] = function (styles) {
       key: 'getStyle',
       value: function getStyle(style, index) {
         var width = this.props.width;
-        if (typeof width !== 'string') width = width + 'px';
 
-        return style(this.state.isOpen, width, this.props.right, index);
+        var formattedWidth = typeof width !== 'string' ? width + 'px' : width;
+        return style(this.state.isOpen, formattedWidth, this.props.right, index);
       }
     }, {
       key: 'listenForClose',

diff --git a/src/baseStyles.js b/src/baseStyles.js
@@ -1,6 +1,6 @@
 'use strict';
 
-let styles = {
+const styles = {
   overlay(isOpen) {
     return {
       position: 'fixed',
@@ -63,10 +63,6 @@ let styles = {
       display: 'block',
       outline: 'none'
     };
-  },
-
-  burgerIcon(isOpen, width, right) {
-    return {};
   }
 };
 

diff --git a/src/menuFactory.js b/src/menuFactory.js
@@ -122,10 +122,9 @@ export default styles => {
     }
 
     getStyle(style, index) {
-      let width = this.props.width;
-      if (typeof width !== 'string') width = `${width}px`;
-
-      return style(this.state.isOpen, width, this.props.right, index);
+      const { width } = this.props;
+      const formattedWidth = typeof width !== 'string' ? `${width}px` : width;
+      return style(this.state.isOpen, formattedWidth, this.props.right, index);
     }
 
     listenForClose(e) {