Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/schema #417

Merged
merged 9 commits into from
Apr 5, 2020
Merged

Feat/schema #417

merged 9 commits into from
Apr 5, 2020

Conversation

brunorzn
Copy link
Contributor

@brunorzn brunorzn commented Apr 5, 2020

Related issues and PRs

Description

Impacted Areas in the application

Testing

JSONSchemaStore is an abstract class, its fetch method needs to be
defined.

I've defined it in a Store class, so using new Store() is not
instanciating an abstract class anymore.

Also, with this change, we can now cross-reference things between
different schema files.
add quicktype and yaml-loader
@vercel
Copy link

vercel bot commented Apr 5, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@ivan-aksamentov ivan-aksamentov merged commit 3b8b299 into neherlab:feat/schema Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants