Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calendar Alignment on Mobile #87

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

bharath6365
Copy link
Contributor

Description

Fixed the logic that decided the number of months that had to be rendered on mobile. Previously it was rendering 4. We have space only to render 1.

Related issues

#71

Impacted Areas in the application

Date Picker

@vercel
Copy link

vercel bot commented Mar 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/covid19-scenarios/covid19-scenarios/6dkctvf9g
✅ Preview: https://covid19-scenarios-git-fork-bharath6365-date-picker.covid19-scenarios.now.sh

@ivan-aksamentov ivan-aksamentov merged commit fb14492 into neherlab:master Mar 22, 2020
@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Mar 22, 2020

Thanks @bharath6365!

Could you please also investigate how it looks on iPad emulator in Chrome?
In particular, regarding the withPortal option of DateRangePicker. For some reason portal rendering is activated on iPad, but not in iPhone X, for example.

Could we avoid hardcoding number of months at all?

I found this storybook to be useful to explore the options:
https://airbnb.io/react-dates

Don't hesitate also if you think that there is a better option than react-dates we can replace it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants