This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Don't sanitize username in ingestion #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
suggested changes
May 17, 2020
There was a problem hiding this comment.
should also be removed from: https://github.com/neicnordic/LocalEGA/blob/master/lega/utils/__init__.py#L18-L20
|
I was thinking about keeping it just in case, but sure, we can remove it. |
|
we can undo changes so keeping code clean is ok. |
blankdots
approved these changes
May 18, 2020
Sensitive Data Archive Development
automation
moved this from Review in progress
to Reviewer approved
May 18, 2020
Sensitive Data Archive Development
automation
moved this from Reviewer approved
to Done
May 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Fixes #43