Skip to content

Commit

Permalink
Merge pull request #7 from neicnordic/docs/missing-mapper
Browse files Browse the repository at this point in the history
mapper core component missing
  • Loading branch information
pontus committed Dec 10, 2020
2 parents 70837d2 + a6caf2e commit c1871ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing guidelines

We thank you in advance :thumbsup: :tada: for taking the time to contribute, whether with *code* or with *ideas*, to the Local EGA project.
We thank you in advance :thumbsup: :tada: for taking the time to contribute, whether with *code* or with *ideas*, to the NeIC SDA project.


## Did you find a bug?
Expand All @@ -18,7 +18,7 @@ We thank you in advance :thumbsup: :tada: for taking the time to contribute, whe

## How to work on a new feature/bug

Create an issue on Github, and talk to the team members on the NBIS local-ega Slack channel. You can alternatively pick one already created.
Create an issue on Github or you can alternatively pick one already created.

Assign yourself to that issue.

Expand Down Expand Up @@ -78,7 +78,7 @@ A code review is initiated when someone has made a Pull Request in the appropria

Work should not continue on the branch _unless_ it is a [Draft Pull Request](https://github.blog/2019-02-14-introducing-draft-pull-requests/). Once the PR is marked ready the review can start.

The initiator of the PR should recruit 2 reviewers that get assigned reviewer duty on the branch. It's not a bad idea to announce this on the #localega slack channel.
The initiator of the PR should recruit 2 reviewers that get assigned reviewer duty on the branch.

Other people may also look at and review the code.

Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Source code for core components (unless specified otherwise) is available at: ht
| verify | Decrypt the stored files and checksum them against their embedded checksum. |
| archive | Storage backend: as a regular file system or as a S3 object store. |
| finalize | Handle the so-called _Accession ID_ to filename mappings from CentralEGA. |
| mapper | The mapper service register mapping of accessionIDs (IDs for files) to datasetIDs. |
| data out API | Provides a download/data access API for streaming archived data either in encrypted or decrypted format - source at: https://github.com/neicnordic/sda-doa |

### Associated components
Expand All @@ -36,4 +37,4 @@ Source code for core components (unless specified otherwise) is available at: ht
| Component | Role |
|---------------|------|
| metadata | Component used in standalone version of SDA. Provides an interface and backend to submit Metadata and associated with a file in the Archive. https://github.com/neicnordic/sda-metadata-mirror/ with UI https://github.com/neicnordic/FormSubmission_UI |
| orchestrate | Component that automates ingestion in stand-alone deployments of SDA Pipeline https://github.com/neicnordic/sda-orchestration |
| orchestrate | Component that automates ingestion in stand-alone deployments of SDA Pipeline https://github.com/neicnordic/sda-orchestration |

0 comments on commit c1871ad

Please sign in to comment.