Dupe initialized fragment value

Fix multiple calls with the same fragment string object
neighborland · Jul 27, 2017 · 639f109 · 639f109
1 parent 08d7edb
commit 639f109
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/cache_rocket/fragment.rb b/lib/cache_rocket/fragment.rb
@@ -5,7 +5,7 @@ class Fragment
     include Key
 
     def initialize(value)
-      @value = value
+      @value = value.to_s.dup
     end
 
     def to_s

diff --git a/test/fragment_test.rb b/test/fragment_test.rb
@@ -34,6 +34,12 @@ def last5(object)
         assert_equal "hey Tiger hey.hey Skunk hey.",
           fragment.replace(replace_hash, collection).to_s
       end
+
+      it "does not modify initialized value" do
+        value = "Hi #{Fragment.new(nil).cache_replace_key(:x)}"
+        assert_equal "Hi 1", Fragment.new(value).replace({ x: "1"}, nil).to_s
+        assert_equal "Hi 2", Fragment.new(value).replace({ x: "2"}, nil).to_s
+      end
     end
   end
 end