Improve env validation and definition #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janl
reviewed
May 31, 2024
| const useSSL = kafkaSecurityProtocol === 'SSL' | ||
| const useSasl = env.get('KAFKA_SASL_MECHANISM') !== undefined | ||
|
|
||
| const saslOptions = useSasl |
There was a problem hiding this comment.
not sure we want this in the default stub. I’d opt for getting folks going fast in a dev env. But we could leave this commented out so folks know they have this path for a live env
There was a problem hiding this comment.
Mmm, maybe. Idk.
ThisIsMissEm
commented
May 31, 2024
| KAFKA_REAUTHENTICATION_TIMEOUT: `Env.schema.number.optional()`, | ||
|
|
||
| // We don't yet support AWS IAM or OAuth Bearer or custom mechanisms | ||
| KAFKA_SECURITY_PROTOCOL: `Env.schema.enum.optional(['PLAIN', 'SSL'])`, |
There was a problem hiding this comment.
may want:
KAFKA_SECURITY_PROTOCOL: the security protocol the hashing service should use when communicating with
the Kafka cluster. Can be set to ssl, plaintext, or sasl_plaintext and defaults to plaintext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #3; I've added logic in to exclude configuration for the
awsandoauthbearermechanisms, since we've not tested them and they can't necessarily be configured via environment variables. I'm not sure if this is a good idea or not?Based on #18