Skip to content

Commit

Permalink
Revert "Support arm64 builds (carvel-dev#85)"
Browse files Browse the repository at this point in the history
This reverts commit 9e4aaee.
  • Loading branch information
neil-hickey committed Jul 7, 2022
1 parent 3f27cca commit 5a1341a
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/kind-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
only: ytt, kapp, kbld
ytt: v0.40.1
kapp: v0.47.0
kbld: v0.34.0
kbld: v0.33.0
# Run benchmark with `go test -bench` and stores the output to a file
- name: Install sg and run e2e tests on kind
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
only: ytt, kapp, kbld, imgpkg
ytt: v0.40.1
kapp: v0.47.0
kbld: v0.34.0
kbld: v0.33.0
imgpkg: v0.29.0
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-gh.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
only: ytt, kapp, kbld
ytt: v0.40.1
kapp: v0.47.0
kbld: v0.34.0
kbld: v0.33.0
- name: Run Tests
run: |
set -e -x
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM --platform=$BUILDPLATFORM golang:1.18.3 AS deps
FROM golang:1.18.3 AS deps

ARG TARGETOS TARGETARCH SGCTRL_VER=development
ARG SGCTRL_VER=development
WORKDIR /workspace

COPY . .
# helpful ldflags reference: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications
RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOSARCH=${TARGETARCH} go build -mod=vendor -ldflags="-X 'main.Version=$SGCTRL_VER' -buildid=" -trimpath -o controller ./cmd/controller/...
RUN CGO_ENABLED=0 GOOS=linux go build -mod=vendor -ldflags="-X 'main.Version=$SGCTRL_VER' -buildid=" -trimpath -o controller ./cmd/controller/...

# --- run ---
FROM scratch
Expand Down
7 changes: 2 additions & 5 deletions config/dev/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sources:
- image: secretgen-controller
path: .
docker:
buildx:
build:
#@ if data.values.dev.rapid_deploy:
pull: false
noCache: false
Expand All @@ -17,10 +17,7 @@ sources:
#! Always rebuild image
pull: true
noCache: true
rawOptions:
- #@ "--build-arg=SGCTRL_VER="+data.values.dev.version
#@ if/end data.values.dev.platform != "":
- #@ "--platform="+data.values.dev.platform
rawOptions: #@ ["--build-arg", "SGCTRL_VER="+data.values.dev.version]
#@ end

#@ if/end data.values.dev.push_images:
Expand Down
2 changes: 0 additions & 2 deletions config/dev/values-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,3 @@ dev:
image_repo: docker.io/k14s/secretgen-controller-test
#@schema/desc "Development version"
version: develop
#@schema/desc "Comma separated list of supported architectures"
platform: ""
7 changes: 2 additions & 5 deletions config/release/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@ sources:
- image: secretgen-controller
path: .
docker:
buildx:
build:
#! Always rebuild image
pull: true
noCache: true
rawOptions:
- #@ "--build-arg=SGCTRL_VER="+data.values.dev.version
#@ if/end data.values.dev.platform != "":
- #@ "--platform="+data.values.dev.platform
rawOptions: #@ ["--build-arg", "SGCTRL_VER="+data.values.dev.version]
---
apiVersion: kbld.k14s.io/v1alpha1
kind: ImageDestinations
Expand Down
4 changes: 1 addition & 3 deletions config/release/values-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@ dev:
#@schema/desc "Location of secretgen-controller image"
image_repo: ghcr.io/neil-hickey/carvel-secretgen-controller
#@schema/desc "Development version"
version: develop
#@schema/desc "Comma separated list of supported architectures"
platform: "linux/amd64,linux/arm64"
version: develop

0 comments on commit 5a1341a

Please sign in to comment.