Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using serde_qs for object serialization to query strings #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MandrakeDeveloper
Copy link

This is a modification to use https://github.com/samscott89/serde_qs for generating query string for Twilio.

I'd like to expand this library in the future and this change allows to do it easily without manually mapping the parameters to URL.

NOTES:

  • Could you please run the tests? You have working configuration very likely. I am still getting setting up everything. Did a quick small test with serde_qs to ensure URL is generated correctly.
  • Not sure if the handling Client::send_request() is the best. Feel free to modify this patch or reimplement as you see fit.
  • Added logging which might be useful in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant