-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to eSignature - v2.1-22.4.02.00 #37
Conversation
Update comment headers in advance as a separate commit, to make it easier to see the real changes.
rm -rf lib/docusign/api/* | ||
rm -rf lib/docusign/model/* | ||
cp -rf /tmp/elixir_api_client/lib/docu_sign/api/* lib/docusign/api | ||
cp -rf /tmp/elixir_api_client/lib/docu_sign/model/* lib/docusign/model | ||
mix format | ||
``` | ||
|
||
NOTE: To minimize differences, also trim trailing whitespace by replacing ` +$` with nothing across all files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine there's a cross-platform way to do this on the command-line as part of the bash steps above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It seemed like some files had trailing spaces trimmed and others didn't.... so 🤷🏻 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine there's a cross-platform way to do this on the command-line as part of the bash steps above.
We can try this:
find . -type f -name "*.ex" -exec sed -i '' 's/[[:space:]]\+$//' {} \;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I tried it on macOS from a fresh copy, but still have trailing spaces (probably more than before).
Alternatively, we could just commit the trailing spaces as-is from the generated code and not worry about it 🤷🏻
(I'm not sure if more files were trimmed than not, or the other way around)
My use of this library is minimal so far -- just sending an email from a template. It still works for me with this update, but maybe other users are willing to try it out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathany-copia thanks for your work on this!
ref: #33
ref: docusign/OpenAPI-Specifications#72