Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to eSignature - v2.1-22.4.02.00 #37

Merged
merged 5 commits into from
Apr 10, 2023

Conversation

nathany-copia
Copy link
Contributor

@nathany-copia nathany-copia commented Mar 16, 2023

  • OpenAPI generator 6.4.0 (ignore the 1st commit when reviewing)
  • as-is update
  • rename number to docuSignNumber
  • rename date to docuSignDate
  • Update instructions
  • Testing this out beyond running the test suite

ref: #33
ref: docusign/OpenAPI-Specifications#72

Update comment headers in advance as a separate commit, to make it easier to see the real changes.
@nathany-copia nathany-copia changed the title [WIP] update to eSignature - v2.1-22.4.02.00 Update to eSignature - v2.1-22.4.02.00 Mar 16, 2023
@nathany-copia nathany-copia marked this pull request as ready for review March 16, 2023 18:13
rm -rf lib/docusign/api/*
rm -rf lib/docusign/model/*
cp -rf /tmp/elixir_api_client/lib/docu_sign/api/* lib/docusign/api
cp -rf /tmp/elixir_api_client/lib/docu_sign/model/* lib/docusign/model
mix format
```

NOTE: To minimize differences, also trim trailing whitespace by replacing ` +$` with nothing across all files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine there's a cross-platform way to do this on the command-line as part of the bash steps above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It seemed like some files had trailing spaces trimmed and others didn't.... so 🤷🏻 )

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine there's a cross-platform way to do this on the command-line as part of the bash steps above.

We can try this:

find . -type f -name "*.ex" -exec sed -i '' 's/[[:space:]]\+$//' {} \;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I tried it on macOS from a fresh copy, but still have trailing spaces (probably more than before).

Alternatively, we could just commit the trailing spaces as-is from the generated code and not worry about it 🤷🏻

(I'm not sure if more files were trimmed than not, or the other way around)

@nathany-copia
Copy link
Contributor Author

My use of this library is minimal so far -- just sending an email from a template. It still works for me with this update, but maybe other users are willing to try it out?

Copy link
Owner

@neilberkman neilberkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathany-copia thanks for your work on this!

@neilberkman neilberkman merged commit 76913ce into neilberkman:main Apr 10, 2023
@nathany-copia nathany-copia deleted the openapi branch April 10, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants