Skip to content

Commit

Permalink
Add completion tests
Browse files Browse the repository at this point in the history
  • Loading branch information
neild3r committed Mar 27, 2017
1 parent 1f30ae7 commit bc9a9fa
Show file tree
Hide file tree
Showing 5 changed files with 74 additions and 7 deletions.
8 changes: 4 additions & 4 deletions src/completions.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {TextDocument, Position, CancellationToken, ProviderResult, CompletionItem, CompletionItemProvider, Range, SnippetString, CompletionItemKind, window} from "vscode";
import { Documenter } from "./documenter";

export class Completions implements CompletionItemProvider
export default class Completions implements CompletionItemProvider
{
protected tags = [
{
Expand Down Expand Up @@ -54,7 +54,7 @@ export class Completions implements CompletionItemProvider
result.push(block);
}

let match = part.match(/.*?(@[a-z])$/);
let match = part.match(/.*?\* (@[a-z]+)$/);

if (match == null) {
return result;
Expand All @@ -66,7 +66,7 @@ export class Completions implements CompletionItemProvider
return tag.tag.match(prefix) !== null;
});

let range:Range = document.getWordRangeAtPosition(position, /@[a-z]/);
let range:Range = document.getWordRangeAtPosition(position, /@[a-z]+/);

potential.forEach(tag => {
let item = new CompletionItem(tag.tag, CompletionItemKind.Snippet);
Expand All @@ -78,4 +78,4 @@ export class Completions implements CompletionItemProvider

return result;
}
}
}
11 changes: 8 additions & 3 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as vscode from 'vscode';
import { spawn, execFile, exec, ChildProcess } from 'child_process';
import * as path from 'path';
import { Documenter } from "./documenter";
import { Completions } from "./completions";
import Completions from "./completions";

export function activate(context: vscode.ExtensionContext) {
vscode.languages.setLanguageConfiguration('php', {
Expand All @@ -29,9 +29,14 @@ export function activate(context: vscode.ExtensionContext) {
]
});

vscode.languages.registerCompletionItemProvider('php', new Completions(), '*');
vscode.languages.registerCompletionItemProvider(
'php',
new Completions(),
'*', '@', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u','v', 'w', 'x', 'y'
);
}

// this method is called when your extension is deactivated
export function deactivate() {
}
}
35 changes: 35 additions & 0 deletions test/completions.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import * as assert from 'assert';
import {TextEditor, TextDocument, CancellationTokenSource, CancellationToken, Position, ProviderResult, CompletionItem} from 'vscode';
import Helper from './helpers';
import Completions from '../src/completions';

suite("Completion tests", () => {
let editor:TextEditor;
let document:TextDocument;
let testPositions:any = {};
let completions = new Completions();

let map = Helper.getFixtureMap('completions.php.json');

suiteSetup(function(done) {
Helper.loadFixture('completions.php', (edit:TextEditor, doc:TextDocument) => {
editor = edit;
document = doc;
testPositions = Helper.getFixturePositions(document);
done();
});
});

map.forEach(testData => {
test("Completion: "+ testData.name, () => {
let pos:Position = testPositions[testData.key];
let result:ProviderResult<CompletionItem[]> = completions.provideCompletionItems(
document,
document.lineAt(pos.line+1).range.end,
new CancellationTokenSource().token
);

assert.equal(testData.tag, result[0].label);
});
});
});
10 changes: 10 additions & 0 deletions test/fixtures/completions.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@


////=> param
* @para

////=> return
* @ret

////=> package
* @pack
17 changes: 17 additions & 0 deletions test/fixtures/completions.php.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
[
{
"key": "param",
"name": "Param tag",
"tag": "@param"
},
{
"key": "return",
"name": "Return tag",
"tag": "@return"
},
{
"key": "package",
"name": "Package tag",
"tag": "@package"
}
]

0 comments on commit bc9a9fa

Please sign in to comment.