Amend regex to prevent incorrect boolean return type #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any method name beginning with
can
,is
orhas
is assumed to return typeboolean
. However this is not always the case, as method names likecancel
orhash
will not necessarily return aboolean
.This PR updates the regex to look for an uppercase letter, or an underscore (for CodeIgniter for example), directly after
can
,is
orhas
to assert that will probably returnboolean
.The change also adds
should
as an boolean-y prefix.I changed the regex to
/^(is|has|can|should)[A-Z_]/
but this would not apply for methods literally calledcan
,is
,has
orshould
. Could update to/^(is|has|can|should)(?:[A-Z_]|$)/