Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more docblock tags #39

Merged
merged 1 commit into from
May 20, 2017
Merged

Conversation

jens1o
Copy link
Contributor

@jens1o jens1o commented May 19, 2017

Love this project, very useful! Thanks!

@neild3r
Copy link
Owner

neild3r commented May 19, 2017

These tags I'm not so sure about as these are not really used anymore due to the fact that they are in the function/class signatures otherwise we'd be generating these automatically. Are we polluting the tag list too much by adding them?

@jens1o
Copy link
Contributor Author

jens1o commented May 19, 2017

I don't think so. In fact, I use them very often, that's why I added them into the snippets. Otherwise I would add them myself. I think it's nice to have to see what the programmer can probably add, and it may select one while typing in @, and so the code itself gets more structured. vscode itself sorts them perfectly after the cost-factor, so they don't pollute at all.

@neild3r neild3r merged commit a4d231a into neild3r:master May 20, 2017
@jens1o jens1o deleted the jens1o-more-docblock branch May 20, 2017 08:41
@jens1o
Copy link
Contributor Author

jens1o commented May 20, 2017

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants