Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prefix method name with $ #56

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Don't prefix method name with $ #56

merged 1 commit into from
Aug 21, 2017

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Aug 21, 2017

Changed autocompletion for @method from:

@method mixed $methodName()

to

@method mixed methodName()

jens1o
jens1o approved these changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neild3r neild3r merged commit 4743159 into neild3r:master Aug 21, 2017
@ADmad ADmad deleted the patch-1 branch August 21, 2017 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ADmad @jens1o @neild3r