Skip to content

Commit

Permalink
Bump gradle version
Browse files Browse the repository at this point in the history
Summary:
This diff updates the minimum gradle plugin version for building the
Hermes OSS release in order to avoid problems in older versions of
the Android NDK.

Specifically, there was a bug
(android/ndk#1166) in the Android NDK that
caused the exception handling functions in `libc++` to be incorrectly
exported. Depending on link order, this can lead to  `libhermes.so`
not statically linking in `_Unwind_resume`, and expecting it instead
to be resolved dynamically to the version in `libc++`. However, if
we're linking against an RN version that was built against the new
version of the NDK, those symbols may not be exported, and end up
unresolved (which crashes the app).

To allow Hermes to be built with newer versions of the NDK, we need
to bump up the gradle plugin version to 4.1. RN already uses 4.1.

Differential Revision: D28763472

fbshipit-source-id: 617749b2b50dbede29205ed43cc3862e36c14ac8
  • Loading branch information
neildhar authored and facebook-github-bot committed May 27, 2021
1 parent 5406ed1 commit 8340357
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:4.0.0'
classpath 'com.android.tools.build:gradle:4.1.0'
classpath("de.undercouch:gradle-download-task:4.0.2")
}
}
Expand Down

0 comments on commit 8340357

Please sign in to comment.