Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Provide a way of ignore custom view helpers, plus update coding style #108

Merged

Conversation

fabiocarneiro
Copy link
Contributor

Ignore custom view helpers by adding the following to the config

return [
    'twbbundle' => [
        'ignoredViewHelpers' => [
            'viewhelpername'
        ]
    ]
];

plus update coding style to pass psr-2 php code sniffer validation

@fabiocarneiro fabiocarneiro force-pushed the update-coding-and-hardcoded-ignore-list branch from 1fb19ae to 120404a Compare October 29, 2014 19:56
@fabiocarneiro fabiocarneiro mentioned this pull request Oct 30, 2014
@neilime
Copy link
Owner

neilime commented Nov 3, 2014

Two any files have been changed, I cannot view what is your update.

@fabiocarneiro
Copy link
Contributor Author

@neilime is it really necessary to have that coverage log in the build folder? couldn't we add it to gitignore?

I removed the changes in the build folder, so now we can see the diff as there are less changes.

@fabiocarneiro fabiocarneiro force-pushed the update-coding-and-hardcoded-ignore-list branch 6 times, most recently from afe9756 to 50c3954 Compare November 3, 2014 21:54
@fabiocarneiro fabiocarneiro force-pushed the update-coding-and-hardcoded-ignore-list branch from 50c3954 to 5705031 Compare November 3, 2014 22:08
@neilime
Copy link
Owner

neilime commented Nov 5, 2014

Why do you have remove all absolute namespaces replacing by use statements ? All the code use absolute namespaces

@fabiocarneiro
Copy link
Contributor Author

@neilime Namespace importing is a language feature. Y not take advantage of it? The code looks much simpler and if you need to replace the class you can do it in the "use" instead of working in the entire class code. Also its a zf2 pattern (take a look at zf2 source code), and since your project is a zf2 module, it makes sense to follow the same code pattern.

neilime added a commit that referenced this pull request Nov 11, 2014
…d-ignore-list

Provide a way of ignore custom view helpers, plus update coding style
@neilime neilime merged commit f1d5b3d into neilime:master Nov 11, 2014
fabiocarneiro added a commit to fabiocarneiro/zf2-twb-bundle that referenced this pull request Nov 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants