Fix Apt Repo Settings

[grubernaut]

This allows kitchen-puppet to determine the correct apt repo to use when
installing Puppet, instead of requiring manual user settings.

Doing this, however, deprecates the configuration of puppet-platform,
as this is now set from the platform configuration in
.kitchen.yml.

I have left the default puppet_apt_repo configuration parameter set to
ubuntu precise. I can be convinced fairly easily to change this to
trusty, yet I don't really see the benefit after the merge of this
patch, as kitchen-puppet will now install the correct apt repo based
on the test-suite's platform without further configuration.

Due to this deprecation we will likely need to increase the minor version from
0 to 1 according to semver rules. cc: @neillturner

As discovered in Issue #67, the puppet repo for ubuntu-precise still
allowed for installation of the hiera-puppet package. This package is
no longer needed if running a version of Puppet 3.x.x or greater.

To circumvent this issue, we no longer install the hiera-puppet
package by default, instead only installing this package when the
install_hiera configuration flag is toggled.

Hiera will still be installed by the puppet-common package for any
version of puppet that is > 3.x.x

[neillturner]

what happens to centos and redhat etc after this change?

[grubernaut]

They are unaffected, as yum flavored distro's use their own separate install mechanism.
https://github.com/neillturner/kitchen-puppet/blob/master/lib/kitchen/provisioner/puppet_apply.rb#L185

https://github.com/neillturner/kitchen-puppet/blob/master/lib/kitchen/provisioner/puppet_apply.rb#L327

[ytsarev]

let's write some specs for that ?

[neillturner]

getting error from travis https://travis-ci.org/neillturner/kitchen-puppet
lib/kitchen/provisioner/puppet_apply.rb:135:7: C: Pass &:platform_name as an argument to default_config instead of a block.
tried a couple of changes and can't get through the checks
need to read up on this
i think it is related to not passing a parameter

[grubernaut]

How did you merge this? It changed the spacing and format of the code, making it fail rubocop lint tests. That's really weird though, that it passes on pull request then when merged the spacing was different. Haven't seen that one before.

And yes @ytsarev I would have liked to write some spec tests for this before merged, will add at a later date.

[grubernaut]

Ah, haha we need to pin rubocop versions or update our code to match the new rubocop version.

The pull request ran with rubocop 0.33.0; and the master build ran with 0.34.0 And indeed, a new version was released before this was merged lol

[neillturner]

ok releasing this. The puppet agent version didn't get updated so it is falling further behind although i don't believe it is used much. Still I will try and bring it up to date so it is consistent when i get time and resources.

[grubernaut]

The release number probably should have been 0.1.0 to conform to semver, but it should be fine.

I'll get some spec tests written for this later in the week