-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and Bug Fixes to Renpho Weight Home Assistant Component #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add api_key login to the vercel service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces several updates and bug fixes to the Renpho Weight Home Assistant component, enhancing stability, functionality, and user experience. Key changes include the addition of proxy support, correction of typos in the development status, and improved error handling mechanisms.
Changes Made
aiohttp_socks
to facilitate proxy configuration, which allows the component to connect through specified proxy servers.Motivation
The motivation behind these changes was driven by community feedback and issues encountered during the initial deployments of the component. Users experienced difficulties particularly around areas with restricted internet access where proxy usage became necessary. Moreover, the need for more descriptive error messages was highlighted as crucial for troubleshooting.
Testing
Changes were locally tested with different network configurations to ensure reliability and functionality. The updates do not affect existing configurations and provide additional capabilities that can be opted into as needed.
Installation and Upgrade
For users upgrading from a previous version, no changes are required in the configuration if proxy settings are not needed. Users looking to utilize the proxy feature should refer to the updated documentation sections.
Final Notes
These improvements aim to make the Renpho Weight Home Assistant component more robust and user-friendly. Community members are encouraged to update and provide feedback on the modifications.
Pull Request Status: Ready for review