fix: broken support for type alias List (fixes #216)

neithere · Jan 19, 2024 · 8f270d0 · 8f270d0
1 parent e79048d
commit 8f270d0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,9 +1,13 @@
 Changelog
 =========
 
-Version 0.31.1 (TODO: DATE)
+Version 0.31.1 (2024-01-19)
 ---------------------------
 
+Bugs fixed:
+
+- broken support for type alias `List` (issue #216).
+
 Enhancements:
 
 - cleaned up the README, rearranged other documentation.

diff --git a/src/argh/assembling.py b/src/argh/assembling.py
@@ -756,7 +756,7 @@ def typing_hint_to_arg_spec_params(
             }
 
         # `list`
-        if type_def == list:
+        if type_def in (list, List):
             return {"nargs": ZERO_OR_MORE}
 
         # `Literal["a", "b"]`

diff --git a/tests/test_typing_hints.py b/tests/test_typing_hints.py
@@ -34,6 +34,7 @@ def test_list():
     guess = TypingHintArgSpecGuesser.typing_hint_to_arg_spec_params
 
     assert guess(list) == {"nargs": "*"}
+    assert guess(List) == {"nargs": "*"}
     assert guess(Optional[list]) == {"nargs": "*", "required": False}
 
     assert guess(List[str]) == {"nargs": "*", "type": str}