Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "namespace" in add_commands() #165

Closed
5 tasks done
neithere opened this issue Feb 15, 2023 · 1 comment
Closed
5 tasks done

Rename "namespace" in add_commands() #165

neithere opened this issue Feb 15, 2023 · 1 comment
Assignees
Milestone

Comments

@neithere
Copy link
Owner

neithere commented Feb 15, 2023

Problem: the "namespace" term is ambiguous in the context of argparse / argh.

  • The argparse.Namespace class represents the result of parsing (returned by ArgumentParser.parse()). It could have been a dictionary of attributes and their values; could have been named ParsingResult.
  • The namespace argument in add_commands() is a str, the name of the, well, namespace for commands in a subparser; a subparser label. The run in prog.py web run.

Options:

Tasks:

  • decide on the name
  • introduce it everywhere in the code
  • document the usage
  • deprecate the old name
  • make sure the deprecation is documented, warnings are tested, removal is scheduled for a future version (e.g. 0.31)
@neithere
Copy link
Owner Author

Will be released in v.0.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant