Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing NekTestCase.run_neknek() #61

Closed
RonRahaman opened this issue Apr 26, 2017 · 3 comments
Closed

implementing NekTestCase.run_neknek() #61

RonRahaman opened this issue Apr 26, 2017 · 3 comments
Assignees

Comments

@RonRahaman
Copy link
Contributor

In #48, I introduced nekBinRun.run_neknek(). We should also implement NekTestCase.run_neknek() as a wrapper.

cc: @kmittal2

@RonRahaman RonRahaman self-assigned this Apr 26, 2017
@stgeke
Copy link
Contributor

stgeke commented Apr 26, 2017 via email

@RonRahaman
Copy link
Contributor Author

Understood. I opened Nek5000/Nek5000#257 as a duplicate.

@RonRahaman
Copy link
Contributor Author

On a related note, it's becoming difficult to keep NekExamples/lib synched up in both Nek5000 and NekExamples.

My suggestion: If NekExamples/lib is a separate repo, and is included as a submodule, it can stay synched between Nek5000 and NekExamples. I think some of us were opposed to submodules in the past, but I think they're incredibly useful.

Any other suggestions?

@adampep adampep closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants