Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel へのデプロイ設定を追加 #31

Merged
merged 3 commits into from Jun 17, 2023

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jun 16, 2023

issueURL

#11

この PR で対応する範囲 / この PR で対応しない範囲

Vercel上にデプロイする為に必要な設定を追加、またその前提でREADMEに Getting Started を追加。

独自ドメインでの動作に関しては別PRで対応する。

Storybook の URL、 スクリーンショット

なし

変更点概要

Vercel上で操作を行いリポジトリ連携を行う事でVercelにデプロイ出来る設定を追加。

それに合わせて以下の2つの対応を実施した。

  • READMEに Getting Started を追加した
  • 他のアプリケーションとポートが被らないように 22222 で起動するように変更

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f8b02e) 100.00% compared to head (8659611) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines           39        39           
  Branches         2         2           
=========================================
  Hits            39        39           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 4:15pm

@keitakn keitakn marked this pull request as ready for review June 17, 2023 16:16
@keitakn keitakn merged commit d29e29b into main Jun 17, 2023
9 checks passed
@keitakn keitakn deleted the feature/issue11/add-vercel-deploy branch June 17, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant