Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

エラーページ用のComponentを作成 #48

Merged
merged 4 commits into from Jul 14, 2023

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jul 13, 2023

issueURL

#41

この PR で対応する範囲 / この PR で対応しない範囲

エラーページ用のComponentが作成され、各エラーページをエラーページ用のComponentを使った形に置き換える。

Storybook の URL、 スクリーンショット

https://647ee6f3dfc9fdebe0ceca01-lzmtkwfzrq.chromatic.com/?path=/story/app-components-errortemplate--default-not-found

変更点概要

ErrorTemplate を作成。

作成した 404, 500 エラーページを再現出来るようになっている。

今後503等の別のエラーが増えた時も対応可能になっている。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Jul 13, 2023
@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 7:35am

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ea39f3b) 100.00% compared to head (5538819) 100.00%.

❗ Current head 5538819 differs from pull request most recent head b9230fb. Consider uploading reports for the commit b9230fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines           55        55           
  Branches         5         5           
=========================================
  Hits            55        55           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@keitakn keitakn marked this pull request as ready for review July 14, 2023 07:46
@keitakn keitakn merged commit 3ba7607 into main Jul 14, 2023
7 checks passed
@keitakn keitakn deleted the feature/issue41/create-error-component branch July 14, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant