@nekochans/lgtm-cat-ui を最新安定版に更新して styled-components への依存を削除 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 74.22% 74.22%
=======================================
Files 48 48
Lines 454 454
Branches 113 113
=======================================
Hits 337 337
Misses 113 113
Partials 4 4 ☔ View full report in Codecov by Sentry. |
keitakn
commented
Jun 2, 2023
| @@ -65,7 +64,7 @@ | |||
| "eslint-plugin-react": "^7.32.2", | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "eslint-plugin-storybook": "^0.6.11", | |||
| "eslint-plugin-styled-components-varname": "^1.0.1", | |||
| "happy-css-modules": "^2.1.1", | |||
There was a problem hiding this comment.
今回は happy-css-modules を使ってみた。
確かにこちらのほうが typed-css-modules よりも使い勝手が良い👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#253
関連 URL
https://lgtm-cat-frontend-git-feature-issue253upgrade-0f4efe-nekochans.vercel.app/
Done の定義
@nekochans/lgtm-cat-uiが最新安定版に更新されている事styled-componentsへの依存部分が削除されている事Storybook の URL もしくはスクリーンショット
UI変更はないのでなし
変更点概要
PRタイトルの通り
@nekochans/lgtm-cat-uiを最新にしてstyled-componentsへの依存箇所を削除。レビュアーに重点的にチェックして欲しい点
特になし
補足情報
インラインコメントに記載