This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
LanguageMenu をCSS Moduleを使った形に置換え #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#276
Done の定義
src/components/Header/LanguageMenuがCSS Moduleに置き換わっている事スクリーンショット or Storybook の URL
変更点概要
タイトルの通り。
今回は単純な変更だとデザイン崩れが発生したので少しリファクタリングも行っている。
具体的には
text-decoration: none;をLinkComponentに対して適応している点です。レビュアーに重点的にチェックして欲しい点
CSSの書き方でリファクタリング出来る余地があれば知りたい:pray:
補足情報
https://zenn.dev/link/comments/aec52742cb4428