This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
GlobalMenu をCSSModuleに置換え #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24:9 error Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events 24:9 error Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interaction
keitakn
commented
May 27, 2023
| <_LinkWrapper> | ||
| <div className={styles.wrapper}> | ||
| <div className={styles['header-wrapper']}> | ||
| <button |
There was a problem hiding this comment.
ESLintのアクセシビリティ関連のエラーが出たのでButtonタグを使うように変更。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#276
Done の定義
GlobalMenuがCSS Modulesに置き換わっている事スクリーンショット or Storybook の URL
変更点概要
タイトルの通り、GlobalMenuをCSS Modulesに置換え。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
インラインコメントに記載。
以下に置換え情報をまとめてある。
https://zenn.dev/link/comments/78308033d7f51e