This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
UploadForm 以外のUpload関連ComponentをCSS Modules に置換え #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESlintの以下のErrorを回避する為にaltテキストを追加 32:9 error img elements must have an alt prop, either with meaningful text, or an empty string for decorative images jsx-a11y/alt-text
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#289
Done の定義
スクリーンショット or Storybook の URL
https://62729802bbcc7d004a663d4c-fsiqegerzy.chromatic.com/?path=/story/templates-uploadtemplate--view-in-japanese
変更点概要
タイトルの通り。UploadForm は変更点が大きいので念の為、別PRにする。
今のところデザイン崩れは置きていない事を確認済。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし