This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Icon用のComponentをCSS Modulesに置換え #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#286
Done の定義
スクリーンショット or Storybook の URL
https://62729802bbcc7d004a663d4c-bpjadfvxrh.chromatic.com/?path=/story/templates-termsorprivacytemplate--view-privacy-policy-in-japanese
変更点概要
PRタイトルの通りです。Storybookのファイル名が間違っていたので修正した。
Storybookの名前を変更するとVRTが機能しなくなってしまうが https://62729802bbcc7d004a663d4c-bpjadfvxrh.chromatic.com/?path=/story/templates-termsorprivacytemplate--view-privacy-policy-in-japanese 等のStoryで差分を確認出来るので問題ないと判断した。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし