This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
npm package をアップグレード #320
Merged
npm package をアップグレード #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#319
このPRで対応すること / このPRで対応しないこと
#319 のDoneの定義を満たす為の実装は全てこのPR内で対応。
スクリーンショット or Storybook の URL
https://62729802bbcc7d004a663d4c-brlfgxuyfe.chromatic.com/
変更点概要
npm packageを最新安定版に更新。
それに伴い以下の対応を実施。
以下の通りCJSは非推奨になったので ES Moduleに対応した。（
vite.config.mtsに変更。）The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
stylelint-config-prettierは不要になったので削除。https://github.com/prettier/stylelint-config-prettier
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし