Use SQL::Maker::SQLType to pass around the typed parameters #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okak#132, but why should we pass-in an value_ref to SQL::Maker::SQLType?)
cho45
added a commit
that referenced
this pull request
Jul 14, 2014
Use SQL::Maker::SQLType to pass around the typed parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #132, strict mode of SQL::Maker disallows the use of arrayrefs as bind parameters, and thus Teng needs to use
SQL::Maker::SQLTypefor passing the typed parameters around.Note: Programming interface provided by
SQL::Maker::SQLTypeis awkward (in the sense that a) designates scalarrefs to be used for passing in the value, b) does not provide a way to fetch the value-type pair in a style that is easy to be passed to$sth->bind_param). However after discussing with @tokuhirom, the conclusion is to not change the current API.