fix(docker-compose): command format incorrect, postgres not fixed #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PA733 拜托看一下这个 PR，之前的没有完全修复 |
|
@Garfield550 也许橘橘可以帮忙测试一下，我这边测试下来没有什么问题了 |
|
抱歉，我在portainer上试的，没在docker-compose模块里面尝试 |
了解了，那我放 portainer 里面试试看w |
PA733
reviewed
Jul 15, 2023
docker-compose.yml
Outdated
| healthcheck: | ||
| test: [ "CMD-SHELL", "redis-cli -e ${REDIS_PASSWORD:+-a \"$REDIS_PASSWORD\"} --no-auth-warning ping" ] | ||
| test: [ "CMD-SHELL", "redis-cli -a $$REDIS_PASSWORD --no-auth-warning ping" ] |
There was a problem hiding this comment.
之前的改动考虑到了空密码和密码含空格的情况。
如果指定了--requirepass ""，那么redis将会被锁死（任何登录操作，redis都会返回NOAUTH Authentication required信息）。
之前的逻辑是，密码为空时不传入--requirepass参数。
-e让认证失败或ping失败时，redis-cli返回非零状态码，这样docker就能正确捕获异常。
--no-auth-warning去掉了在命令行传入密码时，redis-cli的警告信息
There was a problem hiding this comment.
🤔️ 确实没想过这种情况，谢谢指出，那我修正一下
PA733
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.