Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve #38 Changed to be able to set channel #42

Merged
merged 8 commits into from
Jun 7, 2018
Merged

resolve #38 Changed to be able to set channel #42

merged 8 commits into from
Jun 7, 2018

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jun 7, 2018 •
edited
Loading

issueURL

#38

Summary of change

  • Changed to be able to set channel.
  • Add channel to contents of log output.

@keitakn keitakn added this to In progress in php-json-logger Jun 7, 2018
@coveralls
Copy link

coveralls commented Jun 7, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 66

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 130
Relevant Lines: 130
💛 - Coveralls

@keitakn keitakn changed the title [WIP] resolve #38 Changed to be able to set channel resolve #38 Changed to be able to set channel Jun 7, 2018
@keitakn keitakn merged commit 0d30ace into master Jun 7, 2018
php-json-logger automation moved this from In progress to Done Jun 7, 2018
@keitakn keitakn deleted the feature/issue38 branch June 7, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
php-json-logger
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keitakn @coveralls