Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to be able to notify slack #49

Merged
merged 7 commits into from
Jun 17, 2018
Merged

Changed to be able to notify slack #49

merged 7 commits into from
Jun 17, 2018

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jun 16, 2018

Summary

Added processing so that you can notify logs to Slack.

IssueURL

#47

@coveralls
Copy link

Pull Request Test Coverage Report for Build 90

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 130
Relevant Lines: 130

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 16, 2018

Pull Request Test Coverage Report for Build 96

  • 63 of 63 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 192
Relevant Lines: 192

💛 - Coveralls

@keitakn
Copy link
Member Author

keitakn commented Jun 17, 2018

Memo

  • should be able to set Slack's access token
  • The access token used in the test code should be encrypted

@keitakn keitakn changed the title [WIP] 🎉 #47 [WIP] Changed to be able to notify slack Jun 17, 2018
@keitakn keitakn changed the title [WIP] Changed to be able to notify slack Changed to be able to notify slack Jun 17, 2018
@keitakn keitakn added this to In progress in php-json-logger Jun 17, 2018
@keitakn keitakn merged commit d783dce into master Jun 17, 2018
php-json-logger automation moved this from In progress to Done Jun 17, 2018
@keitakn keitakn deleted the feature/issue47 branch June 17, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants