Skip to content

Commit

Permalink
chore: fix some comments (#2279)
Browse files Browse the repository at this point in the history
Signed-off-by: lvyaoting <lvyaoting@outlook.com>
Co-authored-by: ChristopherHX <christopher.homberger@web.de>
  • Loading branch information
lvyaoting and ChristopherHX committed Apr 10, 2024
1 parent 06a1d69 commit ac13a1b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/runner/hashfiles/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ class Summary {
/**
* If the summary buffer is empty
*
* @returns {boolen} true if the buffer is empty
* @returns {boolean} true if the buffer is empty
*/
isEmptyBuffer() {
return this._buffer.length === 0;
Expand Down Expand Up @@ -1840,7 +1840,7 @@ class Pattern {
// Normalize slashes
itemPath = pathHelper.normalizeSeparators(itemPath);
// Append a trailing slash. Otherwise Minimatch will not match the directory immediately
// preceeding the globstar. For example, given the pattern `/foo/**`, Minimatch returns
// preceding the globstar. For example, given the pattern `/foo/**`, Minimatch returns
// false for `/foo` but returns true for `/foo/`. Append a trailing slash to handle that quirk.
if (!itemPath.endsWith(path.sep)) {
// Note, this is safe because the constructor ensures the pattern has an absolute root.
Expand Down
2 changes: 1 addition & 1 deletion pkg/runner/step_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ func TestIsContinueOnError(t *testing.T) {
assertObject.False(continueOnError)
assertObject.Nil(err)

// explcit true
// explicit true
step = createTestStep(t, "continue-on-error: true")
continueOnError, err = isContinueOnError(context.Background(), step.getStepModel().RawContinueOnError, step, stepStageMain)
assertObject.True(continueOnError)
Expand Down

0 comments on commit ac13a1b

Please sign in to comment.