-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolic links in GitHub action repositories are retained (or converted to 0 byte files is --use-new-action-cache
) when used by workflows
#2334
Comments
For me is that flag needed to trigger this. FYI You have |
Act (master) in old action cache mode GitHub Codespace
|
Oh, oops. Well, GitHub changed (for security reasons) away from retaining symbolic links, so the old act behavior hasn't been a match to GitHub's behavior for a while either. I could have had a script that depended on symlinks not being retained which would have broken with the standard act behavior. (Heck, I might...) |
--use-new-action-cache
) when used by workflows
Oh I forget that actions/runner uses
I'm not shure if they were ever preserved by the actions/runner, as the It's easier for me to preserve symlinks correctly than trying to replace them by file contents. I imageine needing to fetch additional data of the git object and modifying the filecollector to optionally follow symlinks. |
I assume this creates a copy instead of preserving the link |
Bug report info
Command used with act
Describe issue
symbolic links in github action repositories are converted to 0 byte files when used by workflows.
Link to GitHub repository
https://github.com/check-spelling-sandbox/sturdy-tribble-2
Workflow content
Relevant log output
Additional information
https://github.com/check-spelling-sandbox/sturdy-tribble-2/actions/runs/9178827583/job/25246453375#step:2:83
The key line is:
Act output:
Fwiw,
--use-new-action-cache
doesn't appear to change thisApparently, the expected results are a file that contains the contents of the resolved link (not a symbolic link).
The text was updated successfully, but these errors were encountered: