implement pre and post steps #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
+ Coverage 57.50% 61.50% +3.99%
==========================================
Files 32 40 +8
Lines 4594 5287 +693
==========================================
+ Hits 2642 3252 +610
- Misses 1729 1781 +52
- Partials 223 254 +31
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
KnisterPeter
force-pushed
the
implement-pre-and-post-steps
branch
from
1b54162
to
701b2c9
Compare
KnisterPeter
changed the base branch from
master
to
remove-composite-runcontext-workaround
|
@nektos/act-maintainers I've added a few test to make sure our post steps run and run in order. |
ZauberNerd
reviewed
Apr 4, 2022
pkg/runner/testdata/uses-composite-with-pre-and-post-steps/action-with-pre-and-post/main.js
Outdated
Show resolved
Hide resolved
pkg/runner/testdata/uses-composite-with-pre-and-post-steps/action-with-pre-and-post/post.js
Outdated
Show resolved
Hide resolved
|
@KnisterPeter this pull request is now in conflict 😩 |
KnisterPeter
force-pushed
the
implement-pre-and-post-steps
branch
from
bd4c230
to
dc184ca
Compare
KnisterPeter
force-pushed
the
remove-composite-runcontext-workaround
branch
from
a711610
to
2d06b71
Compare
|
@KnisterPeter this pull request is now in conflict 😩 |
KnisterPeter
force-pushed
the
implement-pre-and-post-steps
branch
from
dc184ca
to
e107671
Compare
|
@KnisterPeter this pull request is now in conflict 😩 |
KnisterPeter
force-pushed
the
implement-pre-and-post-steps
branch
from
b082c4f
to
3d40f90
Compare
|
@KnisterPeter this pull request is now in conflict 😩 |
|
@KnisterPeter - tested on branch and ready to merge once conflict is fixed |
This commit includes requried changes for running post steps for local and remote actions. This allows general cleanup work to be done after executing an action. Communication is allowed between this steps, by using the action state.
Since composite actions could have multiple pre/post steps inside, we need to run all of them in a single top-level pre/post step. This PR includes a test case for this and the correct order of steps to be executed.
To make sure every post executor/step is executed, it is chained with it's own Finally executor.
Having no step result means we do not run any step (neither pre nor main) and we do not need to run post.
If no pre-if or post-if is given, it should default to 'always()'. This could be set even if there is no pre or post step. In fact this is required for composite actions and included post steps to run.
This PR implements running pre steps for remote actions. This includes remote actions using inside local composite actions.
For post-if conditions the default status check should be always(), while for all other if expression the default status check is success() References: https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runspost-if
KnisterPeter
force-pushed
the
implement-pre-and-post-steps
branch
from
12bc9a1
to
d243b19
Compare
|
@KnisterPeter this pull request has failed checks 🛠 |
cplee
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1010
This change implements action post step in combination with the save-state command.
It does support the
post-ifcondition.There are a few preparations for action pre steps, but it's not fully implemented in this PR.
Closes #626