pkg/runner: add support to replace GitHub's env #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
+ Coverage 57.50% 62.30% +4.79%
==========================================
Files 32 40 +8
Lines 4594 5332 +738
==========================================
+ Hits 2642 3322 +680
- Misses 1729 1744 +15
- Partials 223 266 +43
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
KnisterPeter
requested changes
Jun 7, 2022
There might be use cases where users want to use GitHub's variables in the environment variables, which is a valid use case. This commits adds support for replacement of GitHub's env with GitHub's values. Signed-off-by: André Martins <aanm90@gmail.com>
KnisterPeter
approved these changes
Jun 8, 2022
ChristopherHX
approved these changes
Jun 8, 2022
| - name: print env.variable | ||
| run: | | ||
| echo ${{ env.variable }} | ||
| exit ${{ (env.variable == 'nektos') && '0' || '1'}} |
There was a problem hiding this comment.
This test will fail in forks of act outside of the nektos org, maybe use a different context value like github.event_name. I still approve this change as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be use cases where users want to use GitHub's variables in
the environment variables, which is a valid use case.
This commits adds support for replacement of GitHub's env with GitHub's
values.
Signed-off-by: André Martins aanm90@gmail.com
Fixes: #1195