-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: localcheckout mock #1198
fix: localcheckout mock #1198
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
So, I'm currently playing w/ this in https://github.com/check-spelling/cacti and I noticed:
Specifically:
It's possible this belongs to something else, but ... |
Sounds like you also want to be able to use expressions in this mock ( step.With["path"] )... |
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
+ Coverage 57.50% 61.97% +4.46%
==========================================
Files 32 40 +8
Lines 4594 5404 +810
==========================================
+ Hits 2642 3349 +707
- Misses 1729 1786 +57
- Partials 223 269 +46
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@ChristopherHX this pull request is now in conflict 😩 |
@ChristopherHX this pull request has failed checks 🛠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is way better than skipping in the first place
Merging this before a fix for #1193 was merged, renders local actions unusable( Merged, this change is ready )--no-skip-localcheckout
now feels named wrong, since skipping is replaced by mocking it with docker cpCloses #1112
Replaces other PR's
Closes #1192