Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep action inputs #1215

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: keep action inputs #1215

merged 1 commit into from
Jun 20, 2022

Conversation

KnisterPeter
Copy link
Member

Do not initialize inputs a second time (in pre and main step).
When the action setup already run during pre step, we must not
re-run it during the main step, otherwise the inputs will be
overwritten by possible other action inputs.

This is a regression introduced in #1204

@KnisterPeter KnisterPeter added the kind/bug Something isn't working label Jun 14, 2022
@KnisterPeter KnisterPeter requested a review from a team as a code owner June 14, 2022 07:54
@KnisterPeter KnisterPeter self-assigned this Jun 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 1.33s
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ GIT git_diff yes no 0.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1215 (7263a93) into master (4f8da0a) will increase coverage by 4.81%.
The diff coverage is 76.41%.

@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
+ Coverage   57.50%   62.32%   +4.81%     
==========================================
  Files          32       40       +8     
  Lines        4594     5401     +807     
==========================================
+ Hits         2642     3366     +724     
- Misses       1729     1772      +43     
- Partials      223      263      +40     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/model/workflow.go 54.29% <0.00%> (+3.38%) ⬆️
pkg/container/docker_run.go 15.18% <21.73%> (+9.64%) ⬆️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 44.85% <44.85%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
pkg/artifacts/server.go 67.53% <60.00%> (+0.21%) ⬆️
... and 30 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

KnisterPeter added a commit to xing/act that referenced this pull request Jun 14, 2022
This could be closed when upstream nektos#1215 is merged
github-actions bot pushed a commit to xing/act that referenced this pull request Jun 14, 2022
This could be closed when upstream nektos#1215 is merged
ChristopherHX
ChristopherHX previously approved these changes Jun 16, 2022
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test, but this fix shouldn't wait for a test

github-actions bot pushed a commit to xing/act that referenced this pull request Jun 17, 2022
This could be closed when upstream nektos#1215 is merged
cplee
cplee previously approved these changes Jun 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2022

@KnisterPeter this pull request is now in conflict 😩

@mergify mergify bot added the conflict PR has conflicts label Jun 17, 2022
Do not initialize inputs a second time (in pre and main step).
When the action setup already run during pre step, we must not
re-run it during the main step, otherwise the inputs will be
overwritten by possible other action inputs.
@KnisterPeter KnisterPeter dismissed stale reviews from cplee and ChristopherHX via 7263a93 June 20, 2022 08:23
@mergify mergify bot removed the conflict PR has conflicts label Jun 20, 2022
@mergify mergify bot requested a review from a team June 20, 2022 08:32
@cplee cplee merged commit 1d4c2aa into master Jun 20, 2022
@cplee cplee deleted the fix/keep-inputs branch June 20, 2022 21:58
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2022

refresh

✅ Pull request refreshed

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2022

refresh

✅ Pull request refreshed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants