Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interpolate action input defaults #1376

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

KnisterPeter
Copy link
Member

This fixes the regression to interpolate input defaults which contain
expressions.

This fixes the regression to interpolate input defaults which contain
expressions.
@KnisterPeter KnisterPeter self-assigned this Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.92s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.42s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@KnisterPeter KnisterPeter marked this pull request as ready for review October 7, 2022 10:42
@KnisterPeter KnisterPeter requested a review from a team as a code owner October 7, 2022 10:42
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1376 (54ff401) into master (4f8da0a) will increase coverage by 6.59%.
The diff coverage is 75.40%.

@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
+ Coverage   57.50%   64.10%   +6.59%     
==========================================
  Files          32       41       +9     
  Lines        4594     6383    +1789     
==========================================
+ Hits         2642     4092    +1450     
- Misses       1729     1996     +267     
- Partials      223      295      +72     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 13.06% <12.32%> (+7.52%) ⬆️
pkg/model/planner.go 48.82% <25.00%> (-1.60%) ⬇️
pkg/model/workflow.go 50.97% <32.14%> (+0.05%) ⬆️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 45.87% <45.87%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KnisterPeter KnisterPeter added the kind/bug Something isn't working label Oct 7, 2022
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KnisterPeter

@mergify mergify bot merged commit 3631013 into master Oct 7, 2022
@mergify mergify bot deleted the interpolate-input-defaults branch October 7, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants