Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #1425

Merged
merged 2 commits into from Nov 16, 2022
Merged

Remove dead code #1425

merged 2 commits into from Nov 16, 2022

Conversation

memark
Copy link
Contributor

@memark memark commented Nov 4, 2022

Remove dead code, relates to #831.

@memark memark requested a review from a team as a code owner November 4, 2022 20:30
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1425 (1d1df1e) into master (4f8da0a) will increase coverage by 2.80%.
The diff coverage is 66.46%.

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
+ Coverage   57.50%   60.31%   +2.80%     
==========================================
  Files          32       44      +12     
  Lines        4594     6985    +2391     
==========================================
+ Hits         2642     4213    +1571     
- Misses       1729     2463     +734     
- Partials      223      309      +86     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 12.82% <11.53%> (+7.27%) ⬆️
pkg/model/workflow.go 45.65% <23.80%> (-5.26%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@memark
Copy link
Contributor Author

memark commented Nov 16, 2022

Rule: Automatic merge on approval (queue) In progress — The pull request is the 4th in the queue to be merged

It's been like this for 2 hours now. How do I get it merged?

@ChristopherHX
Copy link
Contributor

It's been like this for 2 hours now. How do I get it merged?

GitHub Actions is so buggy, I removed my affected PR with a failing change from the queue.

The pull_request event was triggered for the wrong commit sha, therefore the expected checks were never satisfied.

@mergify mergify bot merged commit a108f10 into nektos:master Nov 16, 2022
@memark memark deleted the patch-1 branch November 17, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants